search

Qeole / colorediffs

Thunderbird extension to colorize code diffs in messages.
Mozilla Public License 2.0
24 stars 5 forks source link

Unreachable code after return statement #91

Closed kael closed 3 years ago

kael commented 5 years ago

Using ColoredDiffs 0.9 with Thunderbird 60.6.1 (64-bit) Linux, there are these warnings at start:

JavaScript warning: chrome://colorediffs/content/views/side-by-side-view.js, line 348: unreachable code after return statement
JavaScript warning: chrome://colorediffs/content/views/unified-view.js, line 226: unreachable code after return statement
JavaScript warning: chrome://colorediffs/content/views/context-view.js, line 251: unreachable code after return statement

But it doesn't seem to affect the display of git diffs though.

Qeole commented 5 years ago

Yep thanks for the report! I've seen them already and tried to remove the “unreachable” code, but then things would break, if I remember correctly :s. As you mentioned it does not seem to have an impact on the display, so I don't intend to spend much time on it to be honest.

kael commented 5 years ago

Alright. Perhaps I'll give a look.

Thanks for the extension !

Qeole commented 5 years ago

Well I don't even deserve the credit :) I just ended up being the maintainer, but I didn't write the extension.

And yes, if you manage to have a look and find a fix, that would be awesome.

Qeole commented 3 years ago

Obsoleted in v2 by c8436ddca5160c736aaf67326ccbaa08ffb01ae5.