QinbinLi / MOON

Model-Contrastive Federated Learning (CVPR 2021)
MIT License
263 stars 56 forks source link

Questions about the reported test accuracy. #20

Closed Codefmeister closed 1 year ago

Codefmeister commented 1 year ago

Hi! Thanks for your inspiring work. I have a few questions about the reported accuracy in your paper, because I am not familiar with the field of federated learning.

  1. In the section 4.2 Accuracy Comparision, do all client participate in the training(Participation ratio=1.0)?
  2. When under partial participation setting, each round we need to evaluate the current model, so which dataset will the evaluation be conducted on? Will the evaluation be conducted on the selected clients or all clients? If we adopt the first strategy(closer to the practical scenario), how do we get the reported top accuracy? Is the reported top accuracy is the average acc among all clients?
QinbinLi commented 1 year ago

Hi @Codefmeister ,

  1. Yes.
  2. For all experiments including partial participation setting, we evaluate the global model on the global test dataset. There is no local test dataset in our experiments.
Codefmeister commented 1 year ago

Thanks for your answer. It really helps.