search

Qinfeiii / cs2103aug12-w10-4s

Automatically exported from code.google.com/p/cs2103aug12-w10-4s
0 stars 0 forks source link

ID provided do not match sorted id #23

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Perform change/remove command
2. If id is not matching, the wrong item is modified/removed

What is the expected output? What do you see instead?

Potential solution requires edits to UI and command processing.

Original issue reported on code.google.com by ready...@gmail.com on 24 Oct 2012 at 3:12

GoogleCodeExporter commented 9 years ago 
Raised priority to high. Required to be fixed by V0.3 (for software demo).

Original comment by ready...@gmail.com on 25 Oct 2012 at 1:03

GoogleCodeExporter commented 9 years ago 
Will be making changes to CommandProcessor in order to resolve this.

Original comment by jchen...@gmail.com on 25 Oct 2012 at 8:38

GoogleCodeExporter commented 9 years ago 
Fixed as of rev bd6f78307aaa on ui branch. Somewhat inefficient solution - 
noticeable delay when a command is input.

Original comment by jchen...@gmail.com on 25 Oct 2012 at 8:55

GoogleCodeExporter commented 9 years ago 
Fix confirmed. Delay not noticeable on desktop, would try on VM or laptop.

I have a potentially more efficient solution. I'm not sure if listbox items 
property changes based on the filter/sort. If it does (it does appear so), then 
we can just pass the listbox items property to CP, as the items property will 
have mappings of each item's position (use TaskList.GetItemAt(the chosen 
position), the returned object is Entry type). Getting the id from the mappings 
can be done quickly using the CP.TaskList.indexof method.

Original comment by ready...@gmail.com on 25 Oct 2012 at 9:13

GoogleCodeExporter commented 9 years ago 
Sorry, the "listbox.items" that I referred to is actually TaskList.Items in 
MainWindow. :P

Original comment by ready...@gmail.com on 25 Oct 2012 at 9:14