Crashing on tidal error

yaxu commented 4 years ago

On latest OT branch under linux, I'm finding certain Tidal errors result in Troop crashing.

E.g. this syntax error:

d1 $ every 2 sound "bd"

Results in this in the troop post window:

[Errno 32] Broken pipe
"Can't connect to server"

and this on the console:

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/alex/src/Troop/src/receiver.py", line 93, in handle
    raise(e)
EmptyMessageError: 'Message contained no data'

yaxu commented 4 years ago

Things seem happier under python 3, no crashes. I do see some strangeness in the output buffer though which might be related:

Qirky commented 4 years ago

Very strange, I'll have to get my raspberry pi out to test this so might not be until the weekend I'm afraid

Qirky commented 4 years ago

I do get some strange character issues but generally fine with Python 3 on Ubuntu - dropping support for Python 2 anyway but it's probably due to the very hacky way I'm reading from the stdout but there doesn't seem to be a very good way either

yaxu commented 4 years ago

Yep Python 3 is the future !

Qirky / Troop

Crashing on tidal error #37