Enable additional pylint checks

Qiskit-Extensions / circuit-knitting-toolbox

Tools for knitting quantum circuits with Qiskit

https://qiskit-extensions.github.io/circuit-knitting-toolbox/

Apache License 2.0

70 stars 24 forks source link

Enable additional pylint checks #545

Open garrison opened 2 months ago

garrison commented 2 months ago

I ran pylint in its default configuration, and I noticed some additional checks that might be useful to us. We should investigate whether turning each of these on will benefit us. There is currently at least one example of each of the following violations in the code base.

[ ] consider-using-generator
[ ] consider-using-f-string
[ ] unidiomatic-typecheck
[ ] wrong-import-order
[ ] wrong-import-position
[ ] unnecessary-comprehension
[ ] no-else-return
[ ] arguments-renamed
[ ] consider-using-enumerate
[ ] unnecessary-lambda
[ ] consider-merging-isinstance

garrison commented 1 month ago

We'll need to disable wrong-import-order and wrong-import-position on the notebooks, as we deliberately import things right before we use them in the docs. But that will be easy because they are actually processed in a separate call to pylint:

https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/67f24cb4e8e067eebad1f351ce971df8dc115f61/tox.ini#L33