Qiskit-Extensions / circuit-knitting-toolbox

Tools for knitting quantum circuits with Qiskit
https://qiskit-extensions.github.io/circuit-knitting-toolbox/
Apache License 2.0
69 stars 23 forks source link

Tuple unpacking bug fix in cut finder. #591

Closed ibrahim-shehzad closed 1 month ago

ibrahim-shehzad commented 1 month ago

There was a tuple unpacking error that arose when theCutBothWires action was invoked as part of the rest of the cut finding workflow. This bug was not noticed at first because the although existing tests called that line, its output was not used in any part of the rest of the workflow. This bug was noticed in the work leading up to #586 which will also add more comprehensive tests for the CutBothWires action. The goal of this PR is just to fix this bug and edit the corresponding tests and type hints accordingly.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9099874576

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Files with Coverage Reduction New Missed Lines %
circuit_knitting/cutting/cutqc/wire_cutting_evaluation.py 21 84.18%
<!-- Total: 21 -->
Totals Coverage Status
Change from base Build 9084779766: -0.03%
Covered Lines: 3500
Relevant Lines: 3666

💛 - Coveralls