Remove cutQC - Githubissues

Qiskit-Extensions / circuit-knitting-toolbox

Tools for knitting quantum circuits with Qiskit

https://qiskit-extensions.github.io/circuit-knitting-toolbox/

Apache License 2.0

69 stars 23 forks source link

Remove cutQC #605

Closed caleb-johnson closed 1 month ago

caleb-johnson commented 1 month ago

Fixes #519

Remaining action items

[x] Release note
[x] Remove utils/conversion.py and utils/metrics.py
[x] Remove --omit="circuit_knitting/cutting/cutqc/**/*,circuit_knitting/utils/conversion.py,circuit_knitting/utils/metrics.py" from coverage command in tox.ini
[x] Remove cutqc and metrics from addopts line in pyproject.toml, and anything else added temporarily as part of #527
[x] grep for remaining references to cplex (e.g. in the README)

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9225128307

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+4.5%) to 100.0%

Totals
Change from base Build 9184284091:	4.5%
Covered Lines:	2375
Relevant Lines:	2375

💛 - Coveralls

caleb-johnson commented 1 month ago

@garrison why are our release notes not causing problems with sphinx? There are references to cutqc that don't exist anymore. I was assuming our sphinx build would fail in CI due to references to missing package

garrison commented 1 month ago

@garrison why are our release notes not causing problems with sphinx? There are references to cutqc that don't exist anymore. I was assuming our sphinx build would fail in CI

It's because we don't use Sphinx's "nitpicky" mode, so classes that don't exist don't raise errors. I tried experimenting with this mode in #196 but it was a disaster.

garrison commented 1 month ago

OK, maybe my idea to use Docker on macOS was half baked ;) since Docker is apparently not installed on the macOS image that github actions uses.

We can always make this change in a future PR if we really want to test Docker on M series Mac.

garrison commented 1 month ago

Overall coverage increased (+4.5%) to 100.0%

We should throw a party :tada: :rocket: