Thanks to #1342 we can cleanup internals of CompositeCurveAnalysis. Not API break and no feature upgrade with this PR.
Details and comments
Previously the curve data and fit summary data are internally created in CurveAnalysis but immediately discarded. The implementation in CurveAnalysis._run_analysis is manually copied to CompositeCurveAnalysis._run_analysis to access these artifact data to create composite artifact data from them. This makes code fragile since developers needed to manually update both base classes. With this PR, implementation of component analysis is encapsulated.
This is an automatic backport of pull request #1397 done by Mergify.
Summary
Thanks to #1342 we can cleanup internals of
CompositeCurveAnalysis. Not API break and no feature upgrade with this PR.Details and comments
Previously the curve data and fit summary data are internally created in
CurveAnalysisbut immediately discarded. The implementation inCurveAnalysis._run_analysisis manually copied toCompositeCurveAnalysis._run_analysisto access these artifact data to create composite artifact data from them. This makes code fragile since developers needed to manually update both base classes. With this PR, implementation of component analysis is encapsulated.This is an automatic backport of pull request #1397 done by Mergify.