Qiskit-Extensions / qiskit-experiments

Qiskit Experiments
https://qiskit-extensions.github.io/qiskit-experiments/
Apache License 2.0
151 stars 122 forks source link

Fix broken codes #1465

Open nkanazawa1989 opened 4 weeks ago

nkanazawa1989 commented 4 weeks ago

Summary

There were several changes in dependent packages that broke unit test of this package. This PR fixes broken code.

Details and comments

188eb5c8f18f042486c2cd98282dfdc9f1598271, 83feccea334792119a13668ed3f297f86835db0b

After Qiskit >= 1.2, a protected member _parameter_table of the QuantumCircuit is managed in the Rust domain as a part of CircuitData and we cannot directly touch this object from Python, though we should continue to support <= 1.1. These commits add attribute check before copying the table. (edit)

f372eb3efd474457f4b8959cd36d9c2d9ad175be qiskit-ibm-runtime 0.24 was released and deprecation for V1 backends were added. We should switch to V2 backends. Also some property value has been changed in one of our reference backends.

ba2bdce9dabf7e4328abd179b303a177203b88fd

Again, due to the data model update of QuantumCircuit in Qiskit core, a custom circuit equality function used in a unit test was broken. This commit changes approach of the test so that it doesn't need to rely on the custom function.