search

Qiskit / openqasm3_parser

Parser and semantic analyzer for the OpenQASM3 language
Apache License 2.0
10 stars 11 forks source link

Adding from_designator + notes for usage #222

Closed abhamra closed 3 months ago

abhamra commented 3 months ago

Fixes #170: minor changes because error handling for designators within this file wasn't standardized and should stay separated.

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

jlapeyre commented 3 months ago

This PR has a merge conflict. probably because main was updated. I think the updated main branch will fix the CI failure above.

abhamra commented 3 months ago

This PR has a merge conflict. probably because main was updated. I think the updated main branch will fix the CI failure above.

Just rebased my fork, ideally should have fixed the issues.

jlapeyre commented 3 months ago

It's more convenient for the feature branch to have a name other than main. For example, I already have a local branch named main.

This PR should be rebased on the latest main, which includes #221 . .... maybe it is. but edits from #221 are showing up in the online diff here.

abhamra commented 3 months ago

@jlapeyre I see what you mean; I'm reasonably confident I have the changes from main, I think I will make a new PR with a new branch name that doesn't conflict, something like from_designator_fix. The code should be unchanged, just a new PR without the conflict.

jlapeyre commented 3 months ago

Obsolete. Replaced by #224