search

Qiskit / openqasm3_parser

Parser and semantic analyzer for the OpenQASM3 language
Apache License 2.0
11 stars 12 forks source link

Dependency clap has MSRV 1.7 #7

Closed jlapeyre closed 10 months ago

jlapeyre commented 10 months ago

[Manually transferred to this new account]

This is too high for qiskit. Can we:

@mtreinish wrote

In general I'm not sure we need clap for anything in a parser library. Clap is a command line argument parser, if the crates we export as a library shouldn't need an argparser as we won't have a command line interface. If you want to build a standalone parser utility on top of the parser lib then clap would make sense, but as a binary crate it could have an independent msrv.

jlapeyre commented 10 months ago

Yes. Going further, I think the tool in this repo that uses clap is very useful, but only for development. I think there is not a problem with moving clap to a dev dependency.

jlapeyre commented 10 months ago

Turns out that clap already is a dev-dependency. We can skip building the example code, which uses clap with cargo test --lib ...

I guess that clap really does need 1.7.0. Some of the crates that say they need 1.7.0 apparently don't. I can edit the version requirement and they build and tests succeed.

In any case clap is no longer an immediate problem.