Closed techtolentino closed 10 months ago
@vabarbosa - I thought about these pages but didn't fully know if they should be everywhere
maybe they should?
@y4izus?
@vabarbosa - I thought about these pages but didn't fully know if they should be everywhere
at minimum i would say the 404 page should have the banner. i'm ok with leaving the other pages as is though.
at minimum i would say the 404 page should have the banner. i'm ok with leaving the other pages as is though.
@vabarbosa - good idea, updated here https://github.com/Qiskit/platypus/pull/2195/commits/1e9e6ab543b29f4591d5dfce5fbba432027a3e93
I think is enough with that pages, so I'm gonna merge
Changes
Closes #2189
Implementation details
q-one-xp-banner
tosignin.pug
,userAccount.pug
, anderror.pug
templates$one-xp-banner-height-*
variables into thesettings.scss
since it's used in multiple scss files.sign-in
styles to make banner work1px
to thetop
andmax-height
calculations so the bottom-border of the banner would showScreenshots
Sign in and Account pages
https://github.com/Qiskit/platypus/assets/6276074/bf50142b-7dfd-4f44-ba95-9888d2f209ce
Error page
preview of sign in page: https://platypus-pr-2195.ecy0akwlcpw.us-south.codeengine.appdomain.cloud/signin preview of error page: https://platypus-pr-2195.ecy0akwlcpw.us-south.codeengine.appdomain.cloud/test