Qiskit / platypus

Qiskit Textbook (beta)
https://learn.qiskit.org
Apache License 2.0
124 stars 241 forks source link

feat(1xp-banner): add banner to `/signin`, `/account`, and `/error` pages #2195

Closed techtolentino closed 10 months ago

techtolentino commented 10 months ago

Changes

Closes #2189

Implementation details

Screenshots

Sign in and Account pages

https://github.com/Qiskit/platypus/assets/6276074/bf50142b-7dfd-4f44-ba95-9888d2f209ce

Error page Screenshot 2023-09-06 at 2 50 03 PM (2)

preview of sign in page: https://platypus-pr-2195.ecy0akwlcpw.us-south.codeengine.appdomain.cloud/signin preview of error page: https://platypus-pr-2195.ecy0akwlcpw.us-south.codeengine.appdomain.cloud/test

techtolentino commented 10 months ago

@vabarbosa - I thought about these pages but didn't fully know if they should be everywhere

maybe they should?

@y4izus?

vabarbosa commented 10 months ago

@vabarbosa - I thought about these pages but didn't fully know if they should be everywhere

at minimum i would say the 404 page should have the banner. i'm ok with leaving the other pages as is though.

techtolentino commented 10 months ago

at minimum i would say the 404 page should have the banner. i'm ok with leaving the other pages as is though.

@vabarbosa - good idea, updated here https://github.com/Qiskit/platypus/pull/2195/commits/1e9e6ab543b29f4591d5dfce5fbba432027a3e93

y4izus commented 10 months ago

I think is enough with that pages, so I'm gonna merge