The current logic only raises a DiceExecutionError when subprocess.run fails to execute. This isn't the right logic since subprocess.run will successfully execute even if the underlying process returns a non-zero return code. This PR checks the returncode explicitly and raises a DiceExecutionError alerting users to the failure of the Dice command line application and pointing them to the logfile.
The current logic only raises a
DiceExecutionError
whensubprocess.run
fails to execute. This isn't the right logic sincesubprocess.run
will successfully execute even if the underlying process returns a non-zero return code. This PR checks the returncode explicitly and raises aDiceExecutionError
alerting users to the failure of theDice
command line application and pointing them to the logfile.