num_duplicate_paulis cannot distinguish from num_trimmed_paulis - Githubissues

Qiskit / qiskit-addon-obp

Reducing depth of circuits with operator backpropagation

https://qiskit.github.io/qiskit-addon-obp/

Apache License 2.0

27 stars 4 forks source link

num_duplicate_paulis cannot distinguish from num_trimmed_paulis #13

Open caleb-johnson opened 1 month ago

caleb-johnson commented 1 month ago

The reported values extracted in the qiskit_addon_obp.utils.simplify module cannot distinguish the difference between duplicate and trimmed paulis (e.g. due the tolerance).

mrossinek commented 1 month ago

Just some additional info here:

there is already a unittest which should cover this prepared here (it just has to be uncommented once fixed): https://github.com/Qiskit/qiskit-addon-obp/blob/bdd9509fda97992dbb83b012b2574a4476aa6b89/test/utils/test_simplify.py#L110-L113
a fix for this will have to update the following logic which will already disregard close-to-zero values from the entire simplification process: https://github.com/Qiskit/qiskit-addon-obp/blob/bdd9509fda97992dbb83b012b2574a4476aa6b89/qiskit_addon_obp/utils/simplify.py#L122-L125