`canonicalize_control_flow` will be removed in Qiskit 1.0

Qiskit / qiskit-ibm-provider

Qiskit Provider for accessing the IBM Quantum Services: Online Systems and Simulators

https://qiskit.org/ecosystem/ibm-provider/

Apache License 2.0

77 stars 67 forks source link

`canonicalize_control_flow` will be removed in Qiskit 1.0 #805

Closed kt474 closed 9 months ago

kt474 commented 9 months ago

We use canonicalize_control_flow in our transpiler tests here but it is being removed in Qiskit 1.0 (see Qiskit PR )

Can this be replaced with QuantumCircuit.__eq__?

@taalexander @dieris

taalexander commented 9 months ago

I think we need some input from @jakelishman, this was originally needed to make sure eq evaluated correctly

jakelishman commented 9 months ago

Kevin asked me offline before this - since Qiskit/qiskit#10367, QuantumCircuit.__eq__ should have been doing all the necessary canonicalisation within itself, so (in theory) it should work to remove the explicit call.