Simplify GitHub Action (fork PR)

Qiskit / qiskit-ibm-transpiler

Apache License 2.0

15 stars 4 forks source link

Closed Eric-Arellano closed 1 month ago

Eric-Arellano commented 1 month ago

Makes better use of GitHub Action's sensible defaults:

No need to enumerate every type of pull_request event. The default already does what you want: running every time you make a change to the PR
No need to set arguments to actions/checkout
- fetch_depth: 0 results in fetching every single commit, which gets slow as the repository grows. You probably only need the latest commit to run linters and tests

Eric-Arellano commented 1 month ago

Hm, the tests won't work because I'm running CI from a fork. Options:

give me write access
- Be careful who you do this with, and consider revoking access after my changes from this week. You want to minimize security risk
merge on red (not recommended)
one of you recreates the PR on your own branch

y4izus commented 1 month ago

Thank you @Eric-Arellano !! I will give you Write access these days. I think is the better option right now :)

Eric-Arellano commented 1 month ago

Sg. I'll recreate this from a new branch once I have write access.