search

Qiskit / qiskit-serverless

A programming model for leveraging quantum and classical resources
https://qiskit.github.io/qiskit-serverless/
Apache License 2.0
68 stars 31 forks source link

Add dependency parsing grammar for gateway allowlist #1459

Closed psschwei closed 2 months ago

psschwei commented 3 months ago

Summary

Part of #369

This PR adds the dependency specification grammar from PEP 508 (https://peps.python.org/pep-0508/) to use when validating dependencies via the allowlist.

As a temporary measure, it also simplifies the check to only consider the dependency and not a specific version. As such, it has dropped the test for related to dependency version.

Future work should be done to convert the allowlist file from JSON to the standard requirements.txt format, which would allow for easier version checking.

Details and comments

psschwei commented 3 months ago

The gateway pod seems to be restarting in the k8s test, not sure why yet

psschwei commented 3 months ago

huh, it's getting hit with an OOMKilled error... that doesn't happen locally, could just be an issue in the action...

psschwei commented 3 months ago

ok, bumping the resource limits on the gateway fixed the issue

Tansito commented 3 months ago

Good to know because we had the same problem with the scheduler Wed 😂

Tansito commented 3 months ago

Add it on-hold tag until we can work together on this 😄