search

Qiskit / qiskit-serverless

A programming model for leveraging quantum and classical resources
https://qiskit.github.io/qiskit-serverless/
Apache License 2.0
58 stars 27 forks source link

Gateway: whenever JobSubmission client is used set retry logic. #768

Closed IceKhan13 closed 11 months ago

IceKhan13 commented 12 months ago

What is the current behavior?

If cluster is not available for some reason job is failing in an update status loop.

What is the expected behavior?

client to connect to cluster should have retry logic to accommodate for cases when cluster is not yet available.

IceKhan13 commented 12 months ago

Probably it make sense to create a function wrapper for jobclient with retry logic since we are using it in multiple places.

psschwei commented 12 months ago

Not sure how difficult they would be to write, but we should probably try adding tests for these types of scenarios

IceKhan13 commented 12 months ago

yes, I'm trying to carve out some time to boost test coverage for a project. It should not be that difficult. Hopefully in a week or so we have more time :)

Tansito commented 12 months ago

retry logic since we are using it in multiple places

Yeah, I have the feeling that we are implementing a lot of retries in different places. Maybe something that we should start reviewing? Sounds relatively weird. Maybe it's normal until we can implement some kind of watchers or something.

IceKhan13 commented 11 months ago

Closed in https://github.com/Qiskit-Extensions/quantum-serverless/pull/814