Qiskit / qiskit-tutorials

A collection of Jupyter notebooks showing how to use the Qiskit SDK
Apache License 2.0
2.31k stars 1.29k forks source link

Deprecate Qiskit Visualization tutorial #1353

Closed HuangJunye closed 1 year ago

HuangJunye commented 2 years ago

Summary

Replace current Qiskit Visualization notebook with a notebook with deprecation warning. This is part of https://github.com/Qiskit/qiskit-tutorials/issues/1436. Should not be merged before https://github.com/Qiskit/qiskit-terra/pull/8569 is merged

Fixes Qiskit/qiskit#1352

Details and comments

Screenshot

image
review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

HuangJunye commented 2 years ago

@Guillermo-Mijares-Vilarino Can you please review this deprecation notebook?

mtreinish commented 1 year ago

I'm not sure I understand what deprecation means in this context, we don't have a an api contract on our docs. If there is better content available that documents visualizations better than this tutorial we can just redirect this page in the hosted docs (it'll also exist in the stable version docs forever too).

HuangJunye commented 1 year ago

@mtreinish If we are just moving the tutorials from one place to another, it's fine to just redirect. But in this case the content of this tutorial is split into code examples of functions in a few pages. So it's hard to just redirect to one place. Another reason to add the deprecation is to educate our users to use stable version docs. This may not be the ideal process but after discussions with @SooluThomas and @1ucian0 we decided to give this a try.

Eric-Arellano commented 1 year ago

I agree with Matthew that we don't need to deprecate the tutorial. I could imagine us removing all the content and only having a brief prelude that says where to find the new material. But I don't think we need a deprecation period where we still have the old content.

Either way, we're very soon archiving this repo. So we'll recreate this in Terra when the tutorials are copied over.