Qiskit / qiskit-tutorials

A collection of Jupyter notebooks showing how to use the Qiskit SDK
Apache License 2.0
2.3k stars 1.29k forks source link

Deleted 08_factorizers.ipynb. #1368

Closed dlasecki closed 1 year ago

dlasecki commented 1 year ago

Summary

This PR deletes a tutorial involving features recently removed from Qiskit Terra algorithms.

Details and comments

Closes: #1366.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Cryoris commented 1 year ago

This should probably also include renaming of the tutorials after "08" 🙂

woodsp-ibm commented 1 year ago

For the renaming (renumbering) it did not really matter - they are just ordered by names and if there was some numeric "hole" the order would still be fine. This is now renaming the tutorial that is being updated in #1369 under its former name.

woodsp-ibm commented 1 year ago

Can we drop the renaming of the other tutorial (the 09 one) from this PR and make it independent - otherwise we have to coordinate this with #1369.

dlasecki commented 1 year ago

Can we drop the renaming of the other tutorial (the 09 one) from this PR and make it independent - otherwise we have to coordinate this with #1369.

Done.

HuangJunye commented 1 year ago

I was not aware of the deprecation. Adding the relevant PR and issues here

HuangJunye commented 1 year ago

We were thinking about adding deprecation for tutorials as well but we haven't implemented it yet. Perhaps this would be a good one to test as well. @SooluThomas What do you think?

I think the message can be similar to the deprecation message of the Shor class, direct people to the textbook chapter.

ElePT commented 1 year ago

Hi!! @HuangJunye, is there any update on the deprecation of this tutorial? Let me know if there's anything I can help with.

HuangJunye commented 1 year ago

@ElePT https://github.com/Qiskit/qiskit/pull/1655 will add the redirects to the textbook chapter. After it's merged we can merge this one.

ElePT commented 1 year ago

Thank you! @HuangJunye

HuangJunye commented 1 year ago

https://github.com/Qiskit/qiskit/pull/1655 is merged and the redirect is working as intended.