search

Qiskit / qiskit-tutorials

A collection of Jupyter notebooks showing how to use the Qiskit SDK
Apache License 2.0
2.3k stars 1.29k forks source link

Update iterative phase estimation tutorial to primitives #1369

Closed Cryoris closed 1 year ago

Cryoris commented 1 year ago

Summary

Closes #1367.

Details and comments

There wasn't much to do here actually! 🙂

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

woodsp-ibm commented 1 year ago

I have no idea why this tutorial is in algorithms - for me these were around understanding/using function from qiskit.algorithms. This is more a textbook or other more circuit level tutorial for building out something from scratch. I could understand if this was showing qiskit.algorithms.phase_estimators, which includes an IPE, but this is much more basic - seems more like something that could go to community

Cryoris commented 1 year ago

@woodsp-ibm that's a good point, I was surprised to see that this doesn't actually use the QPE algorithm. Maybe we can just removed it in this refactoring then?

woodsp-ibm commented 1 year ago

Maybe we want move this over to the community tutorials or somewhere else to preserve it so as not to lose it as such. But as far as tutorials for qiskit.algorithms I would remove it from there - we could do with one on phase_estimators from algorithms but that is another story I guess!

HuangJunye commented 1 year ago

Regarding removal of the tutorial, I am not sure. I think we can leave it here for the time being. Early next year we are planning to clean up the qiskit-tutorials repo. We can decide where this will go then. What do you think?

woodsp-ibm commented 1 year ago

Regarding removal of the tutorial, I am not sure. I think we can leave it here for the time being. Early next year we are planning to clean up the qiskit-tutorials repo. We can decide where this will go then. What do you think?

This section is supposed to be tutorials for the functionality of qiskit.algorithms - we have a QPE and IQPE there whereas this is totally standalone and built from scratch. If we cannot decide now then I guess it can be delayed until the clean-up, though it should really be somewhere else I think.