search

Qiskit / qiskit-tutorials

A collection of Jupyter notebooks showing how to use the Qiskit SDK
Apache License 2.0
2.3k stars 1.29k forks source link

Update VQE tutorials 02-04 #1376

Closed ElePT closed 1 year ago

ElePT commented 1 year ago

Summary

This PR updates the VQE tutorials to the new algorithm syntax and removes outdated explanations based on deprecated functionality (Expectation, QuantumInstance...). This change allowed me to merge tutorials 02 and 04 into a new "VQE Advanced Options" tutorial.

Closes #1361, #1362, #1363

Details and comments

Merging tutorials 02 and 04 leaves a space for a new 04 tutorial that I think should cover the VQD algorithm.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

randasbeity commented 1 year ago

Thank you

HuangJunye commented 1 year ago

@Guillermo-Mijares-Vilarino Can you please review this PR?

Guillermo-Mijares-Vilarino commented 1 year ago

The content LGTM. The tutorials look cleaner and some of the explanations are better now.

Liked the usage of the AerEstimator name to distinguish it from the Terra implementation.

I only have a small general comment. In general we are trying to encourage the use of "you" instead of "we" for the tutorials, to focus more on the agency of the user instead of being taken by the hand by us.

ElePT commented 1 year ago

Thanks for the feedback! I changed most of the "we"s to "you"s.