Qiskit / qiskit-tutorials

A collection of Jupyter notebooks showing how to use the Qiskit SDK
Apache License 2.0
2.3k stars 1.29k forks source link

Add ``PVQD`` tutorial #1382

Closed Cryoris closed 1 year ago

Cryoris commented 1 year ago

Summary

Add a tutorial on the p-VQD algorithm implemented in Qiskit as PVQD.

Closes: #1373

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Guillermo-Mijares-Vilarino commented 1 year ago

It seems you are getting a timeout error now. You might want to change the following lines from conf.py to change the 180 seconds timeout to another value. If you want to remove it entirely you can do it by changing the 180 to a -1.

cell_timeout = int(os.getenv('QISKIT_CELL_TIMEOUT', 180)) nbsphinx_timeout = cell_timeout

Cryoris commented 1 year ago

Do we still want to run these notebooks in a short amount of time? Because indeed the gradient descent cell does take some minutes to run. Alternatively we could reduce the number of timesteps, e.g. to 10 instead of 100, which might be fast enough for whatever the default is?

Guillermo-Mijares-Vilarino commented 1 year ago

Do we still want to run these notebooks in a short amount of time? Because indeed the gradient descent cell does take some minutes to run. Alternatively we could reduce the number of timesteps, e.g. to 10 instead of 100, which might be fast enough for whatever the default is?

Ideally yes. It's better to reduce the timesteps to make sure you don't surpass the 180 second limit. It's possible that your local machine takes a bit less than CI to run the cells.

Cryoris commented 1 year ago

I reduced the number of timesteps to 10, locally that runs about 60s -- let's see if that worked 🙂

Cryoris commented 1 year ago

@Guillermo-Mijares-Vilarino the checks seem to have passed, even though the status is not reported to GitHub 😄

Edit: I merged the master branch to re-trigger the build and hopefully fix the reporting.