Qiskit / qiskit-tutorials

A collection of Jupyter notebooks showing how to use the Qiskit SDK
Apache License 2.0
2.28k stars 1.28k forks source link

Improves 03_vqe_simulation_with_noise #1467

Closed divshacker closed 11 months ago

divshacker commented 1 year ago

Summary

This PR will Improve 03_vqe_simulation_with_noise

Details and comments

fixes #1404 Part of #1401

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

divshacker commented 1 year ago

Screenshot from 2023-06-04 02-56-28 This code was intentional, or do I update it ? @woodsp-ibm @HuangJunye Asking because this tutorial already have Qiskit primitives and updated functions. So It might be left out intentionally? If There is anything like that please let me know Thanks

divshacker commented 1 year ago

Till now I have updated a few broken links and added some more links to predefined functions. Also, all the images are converted to SVGs.

woodsp-ibm commented 1 year ago

This code was intentional, or do I update it ?

It needs updating - it should have been when algorithms were switched to primitives but seems to have been an oversight. See #1456

divshacker commented 1 year ago

Thanks! Were the figure changes intentional?

No they were not intentional, but it was by default. There won't be any problem as SVG diagrams are better than existing PNG one.

divshacker commented 11 months ago

This PR is ready for review. Thanks