search

Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
4.84k stars 2.29k forks source link

Refactor VF2 scoring rust interface #11134

Open mtreinish opened 8 months ago

mtreinish commented 8 months ago

The implementation makes me wonder if in the future we should have some sort of VF2Scorer class that builds these and holds them as instance data among any other data that is reused between scorings. The reason being to encapsulate the internals of scoring without forcing client code to be aware of them (i.e. rather than threading a bunch of parameters around, we might call a VF2Scorer::score method and pass just the layout).

Originally posted by @kevinhartman in https://github.com/Qiskit/qiskit/pull/11115#pullrequestreview-1702040931

MozammilQ commented 7 months ago

@mtreinish , am I allowed to try this issue?