coveralls
commented
2 weeks ago Pull Request Test Coverage Report for Build 9585037750
Details
- 151 of 160 (94.38%) changed or added relevant lines in 4 files are covered.
- 15 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+0.02%) to 89.785%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| crates/circuit/src/operations.rs | 107 | 116 | 92.24% | ||
| <!-- | Total: | 151 | 160 | 94.38% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| crates/qasm2/src/lex.rs | 3 | 92.37% | ||
| crates/qasm2/src/parse.rs | 12 | 97.15% | ||
| <!-- | Total: | 15 | --> |
| Totals | |
|---|---|
| Change from base Build 9578841868: | 0.02% |
| Covered Lines: | 63705 |
| Relevant Lines: | 70953 |
qiskit-bot
Summary
This PR adds some of the remaining gates from https://github.com/Qiskit/qiskit/issues/12566
XXPlusYYandXXMinusYY. It also adds amultiply_paramfunction that makes the parameter multiplication step a bit more ergonomic (it matches the parameter type and deals with the different logic depending on whether it's a float or a parameter expression). TheRZGatedefinition has been updated to use this function too.This PR also fixes an oversight in the import path of
TGateandTdgGate, which we should add a unit test for.Details and comments
I don't love having to pass the
pytoken around, so I am open to suggestions to improve the implementation.