search

Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
4.83k stars 2.29k forks source link

Fix v2 pulse drawer #12608

Closed nkanazawa1989 closed 1 week ago

nkanazawa1989 commented 1 week ago

Summary

v2 pulse drawer crashes when the draw function is called with a V2 backend that doesn't have configuration and defaults attributes. Since qiskit-ibm-runtime 0.24 was released and fake V1 backends were deprecated, we should to support visualization with fake V2 backends that doen't have configuration and defaults attributes.

Details and comments

qiskit-bot commented 1 week ago

One or more of the following people are relevant to this code:

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9592725734

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/pulse_v2/device_info.py 1 36 2.78%
<!-- Total: 1 36 2.78% -->
Files with Coverage Reduction New Missed Lines %
qiskit/visualization/pulse_v2/device_info.py 1 39.71%
crates/qasm2/src/lex.rs 4 91.86%
crates/qasm2/src/parse.rs 12 96.23%
<!-- Total: 17 -->
Totals Coverage Status
Change from base Build 9585515412: -0.04%
Covered Lines: 63554
Relevant Lines: 70840
💛 - Coveralls
ElePT commented 1 week ago

https://github.com/Mergifyio backport stable/0.46 stable/1.1

mergify[bot] commented 1 week ago

backport stable/0.46 stable/1.1

✅ Backports have been created

* [#12613 Fix v2 pulse drawer (backport #12608)](https://github.com/Qiskit/qiskit/pull/12613) has been created for branch `stable/0.46` * [#12614 Fix v2 pulse drawer (backport #12608)](https://github.com/Qiskit/qiskit/pull/12614) has been created for branch `stable/1.1`
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9596352057

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/pulse_v2/device_info.py 1 36 2.78%
<!-- Total: 1 36 2.78% -->
Files with Coverage Reduction New Missed Lines %
qiskit/visualization/pulse_v2/device_info.py 1 39.71%
crates/qasm2/src/lex.rs 4 92.62%
crates/qasm2/src/parse.rs 6 97.61%
<!-- Total: 11 -->
Totals Coverage Status
Change from base Build 9585515412: -0.01%
Covered Lines: 63573
Relevant Lines: 70840
💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9596940272

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/pulse_v2/device_info.py 1 36 2.78%
<!-- Total: 1 36 2.78% -->
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
qiskit/visualization/pulse_v2/device_info.py 1 39.71%
crates/qasm2/src/lex.rs 5 92.37%
crates/qasm2/src/parse.rs 6 96.69%
<!-- Total: 13 -->
Totals Coverage Status
Change from base Build 9585515412: -0.03%
Covered Lines: 63559
Relevant Lines: 70840
💛 - Coveralls