Fix `CircuitInstruction` legacy iterable typing

Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.

https://www.ibm.com/quantum/qiskit

Apache License 2.0

4.83k stars 2.29k forks source link

Fix `CircuitInstruction` legacy iterable typing #12630

Closed jakelishman closed 1 week ago

jakelishman commented 1 week ago

Summary

The legacy 3-tuple format of CircuitInstruction still exposes the object in the old tuple-like way of (Operation, list[Qubit], list[Clbit]), rather than the new-style attribute access using tuples for the qargs and cargs. This was inadvertantly changed when it moved to Rust.

Details and comments

Fix #12626.

No changelog because it's not in a release version of Qiskit.

qiskit-bot commented 1 week ago

One or more of the following people are relevant to this code:

@Qiskit/terra-core
@kevinhartman
@mtreinish

jakelishman commented 1 week ago

I opened #12631 to track deprecation - I'm just throwing together a PR to do it now too.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9612612289

Details

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
14 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.002%) to 89.736%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	2	92.37%
crates/qasm2/src/parse.rs	12	97.15%
<!--	Total:	14	-->

Totals
Change from base Build 9612593426:	0.002%
Covered Lines:	63511
Relevant Lines:	70775