Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
4.83k stars 2.29k forks source link

Fix type hint in SolovayKitaevDecomposition (backport #12627) #12633

Closed mergify[bot] closed 1 week ago

mergify[bot] commented 1 week ago

Summary

The return type hint of find_basic_approximation method changes from Gate to GateSequence in SolovayKitaevDecomposition class, as implied by self.basic_approximations.

With no remaining mentions of Gate, its corresponding import statement is removed.

Details and comments

Fixes #12559.


This is an automatic backport of pull request #12627 done by Mergify.

qiskit-bot commented 1 week ago

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9613470946

Details


Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.2%
crates/qasm2/src/lex.rs 3 92.62%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 9612307245: 0.04%
Covered Lines: 61835
Relevant Lines: 68749

💛 - Coveralls