Add Rust representation for DCXGate

eliarbel commented 1 week ago

Summary

As the name suggests.

Details and comments

Addresses #12566

ElePT commented 1 week ago

Hi @eliarbel, I have opened a PR with placeholders for all missing standard gates in rust so that we don't have clashing IDs when working on gates in parallel. Do you think it would be helpful? https://github.com/Qiskit/qiskit/pull/12646

eliarbel commented 6 days ago

Hi @eliarbel, I have opened a PR with placeholders for all missing standard gates in rust so that we don't have clashing IDs when working on gates in parallel. Do you think it would be helpful? #12646

Yeap, I've used it. Thanks @ElePT !

qiskit-bot commented 6 days ago

One or more of the following people are relevant to this code:

@Cryoris
@Qiskit/terra-core
@ajavadia
@kevinhartman
@mtreinish

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 9659597446

Details

17 of 18 (94.44%) changed or added relevant lines in 2 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 89.764%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
crates/circuit/src/operations.rs	15	16	93.75%
<!--	Total:	17	18	94.44%	-->

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	4	92.88%
<!--	Total:	4		-->

Totals
Change from base Build 9650973845:	0.01%
Covered Lines:	63795
Relevant Lines:	71070

💛 - Coveralls

eliarbel commented 6 days ago

Can you update the QuantumCircuit.dcx() method to directly append the rust gate too? You can look at cx or h for an example of how to do this.

Good catch! done

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 9665042321

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

18 of 19 (94.74%) changed or added relevant lines in 3 files are covered.
16 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 89.74%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
crates/circuit/src/operations.rs	15	16	93.75%
<!--	Total:	18	19	94.74%	-->

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	4	91.6%
crates/qasm2/src/parse.rs	12	97.15%
<!--	Total:	16	-->

Totals
Change from base Build 9650973845:	-0.01%
Covered Lines:	63777
Relevant Lines:	71069

💛 - Coveralls

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9680341461

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

18 of 19 (94.74%) changed or added relevant lines in 3 files are covered.
35 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.001%) to 89.753%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
crates/circuit/src/operations.rs	15	16	93.75%
<!--	Total:	18	19	94.74%	-->

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/expr.rs	1	94.02%
crates/qasm2/src/lex.rs	2	92.88%
qiskit/synthesis/discrete_basis/solovay_kitaev.py	4	94.74%
qiskit/providers/fake_provider/generic_backend_v2.py	10	94.71%
crates/qasm2/src/parse.rs	18	96.69%
<!--	Total:	35	-->

Totals
Change from base Build 9650973845:	-0.001%
Covered Lines:	63794
Relevant Lines:	71077

Qiskit / qiskit