Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
4.82k stars 2.29k forks source link

Add placeholders for all mising standard gates in Rust #12646

Closed ElePT closed 6 days ago

ElePT commented 1 week ago

Summary

This PR proposes placeholders for all missing gates in https://github.com/Qiskit/qiskit/issues/12566 with a dummy number of qubits and number of parameters (34) that should be replaced with the actual number when implemented. The idea of this proposal is to allow for a better parallelization of the work that avoids conflicts. Note that I don't particularly like this order, and I think we should reorder the lists once the implementations are completed, but I think this order is better than having to resolve conflicts every time we merge a new PR. I have also added annotations in the static vectors to increase readability.

Details and comments

qiskit-bot commented 1 week ago

One or more of the following people are relevant to this code:

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9644456868

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/circuit/src/operations.rs 0 34 0.0%
<!-- Total: 0 34 0.0% -->
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.11%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 9642268925: -0.04%
Covered Lines: 63672
Relevant Lines: 70949

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9645642831

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/circuit/src/operations.rs 0 34 0.0%
<!-- Total: 0 34 0.0% -->
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 92.11%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 9642268925: -0.04%
Covered Lines: 63670
Relevant Lines: 70949

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9648750761

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/circuit/src/operations.rs 0 32 0.0%
<!-- Total: 0 32 0.0% -->
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 91.86%
crates/qasm2/src/parse.rs 6 96.23%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 9648699798: -0.05%
Covered Lines: 63727
Relevant Lines: 71032

💛 - Coveralls