coveralls
commented
5 days ago Pull Request Test Coverage Report for Build 9676345425
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 318 of 353 (90.08%) changed or added relevant lines in 8 files are covered.
- 5 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+0.02%) to 89.737%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| qiskit/circuit/quantumcircuit.py | 4 | 8 | 50.0% | ||
| crates/circuit/src/operations.rs | 260 | 291 | 89.35% | ||
| <!-- | Total: | 318 | 353 | 90.08% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| crates/qasm2/src/expr.rs | 1 | 94.02% | ||
| crates/qasm2/src/lex.rs | 4 | 92.37% | ||
| <!-- | Total: | 5 | --> |
| Totals | |
|---|---|
| Change from base Build 9661630219: | 0.02% |
| Covered Lines: | 64048 |
| Relevant Lines: | 71373 |
Summary
This PR adds Rust implementations for most controlled gates left in https://github.com/Qiskit/qiskit/issues/12566.
CUGateCU1GateCU3GateC3XGateC3SXGateCCZGateThis is done through a newly implemented
make_n_controlled_gatemacro (which is currently limited to adding controls to a 2-qubit gate).Details and comments
I attempted to implement C4XGate but got some issues with the implementation of the FixedIntializer traits for arrays of more than 16 elements. There are workarounds, but given its low priority the implementation has been left for a follow-up.