Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
4.83k stars 2.29k forks source link

Fix some bugs in loading Solovay Kitaev decompositions (backport #12579) #12665

Closed mergify[bot] closed 5 days ago

mergify[bot] commented 5 days ago

Summary

Fixes #12576 and some other small bugs in storing & loading basic approximations for the Solovay Kitaev algorithm.

Details and comments

qiskit-bot commented 5 days ago

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9676490291

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/synthesis/discrete_basis/solovay_kitaev.py 8 9 88.89%
<!-- Total: 9 10 90.0% -->
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 3 93.13%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 9665663824: 0.02%
Covered Lines: 74528
Relevant Lines: 85453

💛 - Coveralls