search

Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
4.82k stars 2.29k forks source link

GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size (backport #12653) #12666

Closed mergify[bot] closed 4 days ago

mergify[bot] commented 5 days ago

Summary

GenericBackendV2 should not accept backends that are too small for certain gates. The following examples should be rejected:

GenericBackendV2(num_qubits=1, basis_gates=["cx", "id"])

GenericBackendV2(num_qubits=2, basis_gates=["ccx", "id"])

@ElePT found this!

This is an automatic backport of pull request #12653 done by Mergify.

mergify[bot] commented 5 days ago

Cherry-pick of e36027c01a5d18b72225502c0fd5021613893623 has failed:

On branch mergify/bp/stable/0.46/pr-12653
Your branch is up to date with 'origin/stable/0.46'.

You are currently cherry-picking commit e36027c01.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    new file:   releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml
    modified:   test/python/providers/fake_provider/test_generic_backend_v2.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   qiskit/providers/fake_provider/generic_backend_v2.py
    both modified:   test/visual/mpl/graph/test_graph_matplotlib_drawer.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

qiskit-bot commented 5 days ago

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9680536175

Details

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.11%
crates/qasm2/src/parse.rs 12 97.15%
<!-- Total: 17 -->
Totals Coverage Status
Change from base Build 9665663824: -0.02%
Covered Lines: 74496
Relevant Lines: 85449
💛 - Coveralls
coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 9686312512

Details

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 92.11%
crates/qasm2/src/parse.rs 12 97.15%
<!-- Total: 18 -->
Totals Coverage Status
Change from base Build 9665663824: -0.02%
Covered Lines: 74496
Relevant Lines: 85449
💛 - Coveralls