Fix clippy warnings on latest stable rust

Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.

https://www.ibm.com/quantum/qiskit

Apache License 2.0

4.82k stars 2.29k forks source link

Fix clippy warnings on latest stable rust #12675

Closed mtreinish closed 3 days ago

mtreinish commented 3 days ago

Summary

In Rust 1.79.0 several new clippy rules were added and/or enabled by default. This was causing some new issues to be flagged when building qiskit with the this release of Rust. This commit fixes these issues flagged by clippy.

Details and comments

qiskit-bot commented 3 days ago

One or more of the following people are relevant to this code:

@Qiskit/terra-core
@kevinhartman
@mtreinish

coveralls commented 3 days ago

Pull Request Test Coverage Report for Build 9705221806

Details

10 of 10 (100.0%) changed or added relevant lines in 4 files are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.02%) to 89.757%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	5	92.37%
crates/qasm2/src/parse.rs	6	97.61%
<!--	Total:	11	-->

Totals
Change from base Build 9703107599:	0.02%
Covered Lines:	63808
Relevant Lines:	71090

💛 - Coveralls

coveralls commented 3 days ago

Pull Request Test Coverage Report for Build 9714466266

Details

10 of 10 (100.0%) changed or added relevant lines in 4 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 89.764%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	2	93.38%
<!--	Total:	2		-->

Totals
Change from base Build 9714383578:	0.02%
Covered Lines:	63813
Relevant Lines:	71090