search

Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
4.82k stars 2.29k forks source link

Validate `order` kwarg in `BitArray.from_bool_array()` #12686

Open shraddha-aangiras opened 3 days ago

shraddha-aangiras commented 3 days ago

Summary

The kwarg order in BitArray.from_bool_array() should be 'little' or 'big'. Change raises an error if order is neither of the two. Fixes #12673

Details and comments

qiskit-bot commented 3 days ago

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

CLAassistant commented 3 days ago

CLA assistant check
All committers have signed the CLA.

t-imamichi commented 3 days ago

Thank you for fixing the issue. Could you add a test to catch this error and a release note of bugfix?