search

Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
5.04k stars 2.33k forks source link

Documentation of `dag_drawer` is unclear on allowed types #13021

Open jakelishman opened 3 weeks ago

jakelishman commented 3 weeks ago

Talking about qiskit.visualization.dag_visualization:

          What's the reason to have a `not isinstance(dag, DAGCircuit)` path in this function?

_Originally posted by @jakelishman in https://github.com/Qiskit/qiskit/pull/12550#discussion_r1713726314_

The documentation of dag_drawer implies that only DAGCircuit is allowable, but actually the function is intended to work with DAGDependency as well. We should update the documentation to be accurate.

azhar-ikhtiarudin commented 2 weeks ago

Hi, I am new to contributing to Qiskit and would like to learn. Is this issue still open, and may I be assigned to it? Thank you.

AngeloDanducci commented 1 week ago

@azhar-ikhtiarudin assigned, thanks!