Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
5.11k stars 2.34k forks source link

Consider deprecating use of `dag` keyword in `DAGNode` constructors #13022

Open jakelishman opened 1 month ago

jakelishman commented 1 month ago
          Shall we take a note to issue a deprecation warning on the use of the `dag` keyword argument in Qiskit 1.4, and document + release note that the argument is unused as of 1.3?

_Originally posted by @jakelishman in https://github.com/Qiskit/qiskit/pull/12550#discussion_r1713997777_

The dag argument to DAGNode subclasses is irrelevant since the move of the DAGCircuit to Rust space, so the argument no longer has a meaning. It's a candidate for deprecation in 1.4 and removal in 2.0.