search

Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
5.28k stars 2.37k forks source link

Fix Rust-space `TwoQubitBasisDecomposer` for non-standard KAK gate (backport #13014) #13026

Closed mergify[bot] closed 2 months ago

mergify[bot] commented 2 months ago

Summary

Proposal to fix #12998. I can probably extend the unit tests further.

Details and comments

This is an automatic backport of pull request #13014 done by Mergify.

qiskit-bot commented 2 months ago

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

ElePT commented 2 months ago

It looks like the fix cannot be backported unless we also backport CircuitData.from_packed_operation (https://github.com/Qiskit/qiskit/pull/12943).

ElePT commented 2 months ago

The PR will be mergeable after #13038 :)

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10573179702

Details

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 5 92.48%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 10564937123: 0.09%
Covered Lines: 66905
Relevant Lines: 74482
💛 - Coveralls