coveralls
commented
1 month ago Pull Request Test Coverage Report for Build 10740673998
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 104 of 111 (93.69%) changed or added relevant lines in 1 file are covered.
- 106 unchanged lines in 10 files lost coverage.
- Overall coverage increased (+0.008%) to 89.155%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| crates/circuit/src/dag_circuit.rs | 104 | 111 | 93.69% | ||
| <!-- | Total: | 104 | 111 | 93.69% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| qiskit/transpiler/passes/optimization/split_2q_unitaries.py | 1 | 96.77% | ||
| qiskit/transpiler/passes/routing/stochastic_swap.py | 1 | 95.39% | ||
| crates/accelerate/src/synthesis/clifford/utils.rs | 1 | 78.06% | ||
| crates/circuit/src/dag_node.rs | 3 | 81.2% | ||
| crates/qasm2/src/lex.rs | 3 | 93.23% | ||
| crates/circuit/src/packed_instruction.rs | 11 | 93.08% | ||
| crates/circuit/src/circuit_instruction.rs | 12 | 82.93% | ||
| crates/circuit/src/operations.rs | 13 | 88.67% | ||
| crates/accelerate/src/results/marginalization.rs | 17 | 90.17% | ||
| crates/circuit/src/dag_circuit.rs | 44 | 88.92% | ||
| <!-- | Total: | 106 | --> |
| Totals | |
|---|---|
| Change from base Build 10720509731: | 0.008% |
| Covered Lines: | 72737 |
| Relevant Lines: | 81585 |
qiskit-bot
ElePT
raynelfss
kevinhartman
mtreinish
Solves #13003
Summary
Tracked by #13001 and preceeded by #12975 The following commits aim to add a
DAGCircuit::extend()to add a chain ofDAGOpNodesto the DAGCircuit based on a sequence ofPackedInstruction.Details and comments
These commits add the following two methods:
DAGCircuit::extend()to add a sequence ofPackedInstructioncontinously avoiding having to re-add each bit/var's output node each time an instruction is added. The addition of the output node is only performed once all instructions have been added correctly to the DAGCircuit.Known issues:
PyObjectwhich are not hashable.One possible solution would be to use a.PyDicthowever the structures that are being stored within this mapping are rust-native (NodeIndex,Wire)Another solution would be to somehow internalize these structures, which I'm still thinking on how to do.Blockers