Port RemoveDiagonalGatesBeforeMeasure to rust

ShellyGarion commented 1 month ago

Summary

close #12255

Details and comments

qiskit-bot commented 1 month ago

One or more of the following people are relevant to this code:

@Qiskit/terra-core
@kevinhartman
@mtreinish

ShellyGarion commented 4 weeks ago

the failing test should be fixed after https://github.com/Qiskit/qiskit/pull/13067 is merged

ShellyGarion commented 4 weeks ago

Performance comparison of the old python code and the new rust code for a random_circuit:

n_qubits	depth	time is sec of old Python code	time in sec of new rust code
5	1024	0.06	0.00
14	1024	0.47	0.02
20	1024	0.92	0.04

coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 10719300369

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

75 of 76 (98.68%) changed or added relevant lines in 5 files are covered.
120 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.005%) to 89.186%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
crates/accelerate/src/remove_diagonal_gates_before_measure.rs	65	66	98.48%
<!--	Total:	75	76	98.68%	-->

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	5	91.98%
qiskit/visualization/gate_map.py	115	6.69%
<!--	Total:	120	-->

Totals
Change from base Build 10708280718:	0.005%
Covered Lines:	72673
Relevant Lines:	81485

Qiskit / qiskit