Closed Cryoris closed 2 months ago
One or more of the following people are relevant to this code:
@Qiskit/terra-core
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
crates/circuit/src/dag_node.rs | 3 | 81.2% | ||
crates/circuit/src/operations.rs | 3 | 88.5% | ||
crates/qasm2/src/lex.rs | 4 | 91.73% | ||
crates/circuit/src/circuit_instruction.rs | 5 | 85.14% | ||
<!-- | Total: | 15 | --> |
Totals | |
---|---|
Change from base Build 10721003464: | 0.02% |
Covered Lines: | 72657 |
Relevant Lines: | 81481 |
Summary
Fixes the remaining problems with #12970.
Details and comments
If we run
Split2QUnitaries
with an incomplete 1-q basis gate set, we can end up in the situation where a supported gate is split into 2UnitaryGate
objects that might not be representable in the current basis gate set. For exampleThis PR fixes the behavior by only running on
UnitaryGate
objects -- hence not changing the gate types existing in the circuit.