Closed mergify[bot] closed 2 months ago
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the following people are relevant to this code:
@Qiskit/terra-core
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
crates/circuit/src/packed_instruction.rs | 1 | 96.21% | ||
crates/accelerate/src/results/marginalization.rs | 1 | 90.45% | ||
crates/accelerate/src/synthesis/clifford/utils.rs | 1 | 78.06% | ||
crates/qasm2/src/lex.rs | 2 | 92.98% | ||
crates/circuit/src/circuit_instruction.rs | 7 | 86.33% | ||
crates/circuit/src/operations.rs | 7 | 88.31% | ||
<!-- | Total: | 19 | --> |
Totals | |
---|---|
Change from base Build 10719167310: | 0.005% |
Covered Lines: | 66861 |
Relevant Lines: | 74473 |
Summary
Fixes the remaining problems with #12970.
Details and comments
If we run
Split2QUnitaries
with an incomplete 1-q basis gate set, we can end up in the situation where a supported gate is split into 2UnitaryGate
objects that might not be representable in the current basis gate set. For exampleThis PR fixes the behavior by only running on
UnitaryGate
objects -- hence not changing the gate types existing in the circuit.This is an automatic backport of pull request #13095 done by Mergify.