Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
5.1k stars 2.34k forks source link

Fix clippy failures with Rust 1.81.0 #13100

Closed mtreinish closed 3 weeks ago

mtreinish commented 3 weeks ago

Summary

The recently released Rust 1.81.0 introduced some new on by default clippy rules and these rules are flagging issues in the rust code in the library. While we use Rust 1.70 for clippy in CI and these won't cause failures until we raise our MSRV to >= 1.81.0 these clippy warnings/failures are still good to fix as the either make the code more consise and/or efficient. This commit fixes these issues identified by clippy.

Details and comments

qiskit-bot commented 3 weeks ago

One or more of the following people are relevant to this code:

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 10728786660

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/accelerate/src/remove_diagonal_gates_before_measure.rs 1 2 50.0%
crates/circuit/src/operations.rs 0 1 0.0%
<!-- Total: 3 5 60.0% -->
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 90.82%
crates/qasm2/src/lex.rs 3 92.48%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 10725151093: 0.009%
Covered Lines: 72600
Relevant Lines: 81422

💛 - Coveralls