Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
5.1k stars 2.34k forks source link

Fix skipping of slow tests #13119

Closed Cryoris closed 3 weeks ago

Cryoris commented 3 weeks ago

Summary

Tests with the @slow_test decorators should only be run on-demand, but currently are executed in every CI run. We likely didn't notice this since there is only a single slow test at the moment.

Details and comments

It looks like a tiny logic bug, missing a not 🙂 If necessary, we could maybe add a test setting the environment variable QISKIT_TEST, but it seems straightforward enough as fix and works as expected locally.

No reno as this is not user facing.

qiskit-bot commented 3 weeks ago

One or more of the following people are relevant to this code:

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 10792560171

Details


Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 93.23%
crates/qasm2/src/parse.rs 12 97.15%
<!-- Total: 14 -->
Totals Coverage Status
Change from base Build 10774677144: -0.009%
Covered Lines: 73024
Relevant Lines: 81897

💛 - Coveralls