Fix the matrix representation of `CUGate` in Rust

Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.

https://www.ibm.com/quantum/qiskit

Apache License 2.0

5.1k stars 2.34k forks source link

Fix the matrix representation of `CUGate` in Rust #13121

Closed Cryoris closed 3 weeks ago

Cryoris commented 3 weeks ago

Summary

Fixed #13118.

Details and comments

The matrix representation of CUGate in Rust accidentally swapped two arguments (phi and lam). This didn't fail the tests, because there all parameters are set to the same value. The tests are therefore also updated to vary the parameters values within a gate.

qiskit-bot commented 3 weeks ago

One or more of the following people are relevant to this code:

@Qiskit/terra-core
@kevinhartman
@mtreinish

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 10794415482

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.001%) to 89.174%

Files with Coverage Reduction	New Missed Lines	%
crates/accelerate/src/two_qubit_decompose.rs	1	90.82%
crates/qasm2/src/lex.rs	5	92.23%
<!--	Total:	6	-->

Totals
Change from base Build 10774677144:	-0.001%
Covered Lines:	73031
Relevant Lines:	81897