Closed mergify[bot] closed 2 months ago
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the following people are relevant to this code:
@Qiskit/terra-core
We need to backport this in order to merge #13114 onto stable/1.2
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
crates/qasm2/src/expr.rs | 1 | 94.02% | ||
crates/qasm2/src/lex.rs | 3 | 93.23% | ||
crates/qasm2/src/parse.rs | 12 | 97.15% | ||
<!-- | Total: | 16 | --> |
Totals | |
---|---|
Change from base Build 10735835379: | 0.0% |
Covered Lines: | 66862 |
Relevant Lines: | 74473 |
Summary
Tests with the
@slow_test
decorators should only be run on-demand, but currently are executed in every CI run. We likely didn't notice this since there is only a single slow test at the moment.Details and comments
It looks like a tiny logic bug, missing a
not
🙂 If necessary, we could maybe add a test setting the environment variableQISKIT_TEST
, but it seems straightforward enough as fix and works as expected locally.No reno as this is not user facing.
This is an automatic backport of pull request #13119 done by Mergify.