Qiskit / qiskit

Qiskit is an open-source SDK for working with quantum computers at the level of extended quantum circuits, operators, and primitives.
https://www.ibm.com/quantum/qiskit
Apache License 2.0
5.28k stars 2.37k forks source link

Remove duplicated weyl_coordinates python function #13193

Closed mtreinish closed 1 month ago

mtreinish commented 2 months ago

Summary

This commit removes the weyl_coordinates() function from the private qiskit.synthesis.two_qubit.weyl module. This function's internal use was ported to rust as part of #11019 but it left the python implementation intact while we ensured the rust implementation was reliable longer term. Since then we've ported the majority of the two qubit synthesis to rust now and the only usage of this python implementation was the unit tests. This commit removes the python implementation and the entire internal weyl module as nothing uses it anymore. A python interface is added to the rust function and the tests are updated to call that instead.

Details and comments

Fixes: #8459

qiskit-bot commented 2 months ago

One or more of the following people are relevant to this code:

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10947950215

Details


Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 92.73%
crates/qasm2/src/parse.rs 12 97.15%
<!-- Total: 15 -->
Totals Coverage Status
Change from base Build 10947873036: -0.02%
Covered Lines: 73449
Relevant Lines: 82730

💛 - Coveralls