Closed mergify[bot] closed 2 months ago
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the following people are relevant to this code:
@Qiskit/terra-core
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
crates/qasm2/src/expr.rs | 1 | 94.02% | ||
crates/qasm2/src/lex.rs | 6 | 91.98% | ||
crates/qasm2/src/parse.rs | 12 | 97.15% | ||
<!-- | Total: | 19 | --> |
Totals | |
---|---|
Change from base Build 10959931349: | -0.02% |
Covered Lines: | 66877 |
Relevant Lines: | 74508 |
Summary
We previously had a qiskit-bot notification trigger for changes to the rust source or cargo configuration that would list myself and
@kevinhartman
as the relevant reviewers. While this is still true, as Qiskit is now >16% Rust (by lines of code, excluding tests) and that ratio will only grow over time, the two of us are hardly the only people worth calling out specifically as reviewers of rust code. Instead of expanding the list to include the entirety of the terra-core team individually this just removes the custom notification rule and opts to fallback to the default terra-core entry.Details and comments
This is an automatic backport of pull request #13198 done by Mergify.