Closed javabster closed 1 year ago
@javabster is only add the images in the snapshot test?
@MaldoAlberto the issue I'm facing is that new screenshots are not being generated for the announcement banner tests 😅 I'm not sure what's going wrong, possibly because the docker setup is not realising that the option has been set in the conf.py? I'm not really sure
@javabster I saw the images from announcement is not created, because not exist a html file to obtain the snapshot, the others I found in example_docs/docs/_build/html
yeah I don't really understand what is happening with these snapshots tbh, when I was doing my dev work locally I was able to build with the announcement banner in the example_docs, but for some reason when I try run the snapshots workflow (I'm trying to follow the instructions in the contributing guide) the banner isn't getting generated for some reason? I'm trying to figure out how the docker image is getting built but I'm a bit lost tbh.
Also no idea why the CI snapshots keep failing when the "actual" images look exactly the same as the originals 😅
I found the path for the announcement is example_docs/docs/_ecosystem_build/index.html
but the others are in
example_docs/docs/_build/
and yes the error is weird say the size of the image is different for one pixel
Looks good! I only have one suggestion but it's non-blocking.
If I'm not mistaken, this needs to add the announce snapshots
I adjusted the padding of the banner and made it so that users can configure the text used for the link (it defaults to "Learn more" unless specified in conf.py)
Issue created to add snapshot tests: https://github.com/Qiskit/qiskit_sphinx_theme/issues/533
@javabster I'm sorry I'm just seeing your comment in slack about padding! Can we increase top/bottom padding from 14px to 16px?
In this PR:
I'm struggling to figure out how to add new snapshots for this component, any help appreciated!